linux-kernel - Re: Is via-velocity broken in 2.6.34?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin6RcDPFWpG4YBRF4O-8nrsA6e77K=knBA-uyf9@mail.gmail.com>
Date:	Tue, 7 Sep 2010 17:13:14 -0700
From:	Matt Causey <matt.causey@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: Is via-velocity broken in 2.6.34?

On Tue, Sep 7, 2010 at 4:33 PM, David Miller <davem@...emloft.net> wrote:
>
> Please always CC: netdev@...r.kernel.org for networking reports.
>
> Give this patch a try:
>
> --------------------
> via-velocity: Turn scatter-gather support back off.
>
> It causes all kinds of DMA API debugging assertions and
> all straight-forward attempts to fix it have failed.
>
> So turn off SG, and we'll tackle making this work
> properly in net-next-2.6
>
> Reported-by: Dave Jones <davej@...hat.com>
> Tested-by: Dave Jones <davej@...hat.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  drivers/net/via-velocity.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
> index fd69095..f534123 100644
> --- a/drivers/net/via-velocity.c
> +++ b/drivers/net/via-velocity.c
> @@ -2824,7 +2824,7 @@ static int __devinit velocity_found1(struct pci_dev *pdev, const struct pci_devi
>        netif_napi_add(dev, &vptr->napi, velocity_poll, VELOCITY_NAPI_WEIGHT);
>
>        dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_FILTER |
> -               NETIF_F_HW_VLAN_RX | NETIF_F_IP_CSUM | NETIF_F_SG;
> +               NETIF_F_HW_VLAN_RX | NETIF_F_IP_CSUM;
>
>        ret = register_netdev(dev);
>        if (ret < 0)

So before I posted to the list, I actually dug through looking for
recent changes which would be trivial for me to back out.  This was
the only one I had found, so I tried it.  :-)  No luck though...same
result.

Thanks,

--
Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/