linux-kernel - Re: [PATCH] watchdog: add f71862fg support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100910234852.GB18142@salidar.me.mortis.eu>
Date:	Sat, 11 Sep 2010 01:48:52 +0200
From:	Giel van Schijndel <me@...tis.eu>
To:	Lutz Ballaschke <vegan.grindcore@...glemail.com>
Cc:	Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: add f71862fg support

On Sat, Sep 11, 2010 at 01:24:07 +0200, Lutz Ballaschke wrote:
> On Fri, Sep 10, 2010 at 11:03:01 +0200, Wim Van Sebroeck wrote:
>>> Given that the F71862 has *two* pins assignable to the WDTRST#
>>> signal, please document that fact, and the reason for choosing this
>>> one in the code.
>>> 
>>> Perhaps it might even be desirable to insert a printk there.  This
>>> to make the user aware of the fact that this driver might not work
>>> if the pin configuration of their hardware doesn't match the
>>> assumption you make about it in this code.
>> 
>> I propose to Document it in the code and add a module-parameter so
>> that it is selectable.
> 
> I agree. I will post the patch again (missing parts will follow soon). 
> I placed printk in watchdog_start(). Since this means printk output 
> everytime /dev/watchdog is opened I'm not sure whether i like it there. 
> Maybe it fits better in f71808e_find(). But this would require
> additional if / else and stuff. 

Can't you fit that printk in the switch(devid) block?  That wouldn't
require additional logic.  In fact, if you make the selected pin
configurable I wouldn't consider a printk explaining the current
policy/config assumptions necessary because that way there aren't any
policy-related assumptions made in the driver anymore.

-- 
Met vriendelijke groet,
With kind regards,
Giel van Schijndel
--
"It would seem that perfection is attained not when no more can be
 added, but when no more can be removed."
  -- Antoine de Saint Exupéry

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)