linux-kernel - Re: [PATCH] watchdog: add f71862fg support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Sep 2010 01:24:07 +0200
From:	Lutz Ballaschke <vegan.grindcore@...glemail.com>
To:	Wim Van Sebroeck <wim@...ana.be>
Cc:	me@...tis.eu, linux-watchdog@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: add f71862fg support

On Fri, Sep 10, 2010 at 11:03:01AM +0200, Wim Van Sebroeck wrote:
> 
> > Given that the F71862 has *two* pins assignable to the WDTRST# signal,
> > please document that fact, and the reason for choosing this one in the
> > code.
> > 
> > Perhaps it might even be desirable to insert a printk there.  This to
> > make the user aware of the fact that this driver might not work if the
> > pin configuration of their hardware doesn't match the assumption you
> > make about it in this code.
> 
> I propose to Document it in the code and add a module-parameter so that it is selectable.
>
I agree. I will post the patch again (missing parts will follow soon). 
I placed printk in watchdog_start(). Since this means printk output 
everytime /dev/watchdog is opened I'm not sure whether i like it there. 
Maybe it fits better in f71808e_find(). But this would require
additional if / else and stuff. 

Regards,
Lutz Ballaschke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/