linux-kernel - Re: [PATCH] Add Intel Poulsbo Stub Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <4C8A4285020000230002020B@novprvlin0050.provo.novell.com>
Date:	Thu, 09 Sep 2010 22:36:53 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<randy.dunlap@...cle.com>
Cc:	<mjg@...hat.com>, <mjg59@...f.ucam.org>, <gregkh@...e.de>,
	<trenn@...e.de>, <linux-acpi@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <Dennis.Jansen@....de>
Subject: Re: [PATCH] Add Intel Poulsbo Stub Driver

Hi Randy, 

First, thank's for your review!
And, sorry I am late to reply the mail.

於 三，2010-09-01 於 10:11 -0700，Randy Dunlap 提到：
> On Wed,  1 Sep 2010 17:08:39 +0800 Lee, Chun-Yi wrote:
> 
> > Currently, there have no Poulsbo native video driver to support
> > intel opregion. So, use this stub driver to enable the acpi backlight
> > control sysfs entry files by requrest acpi_video_register.
> > 
> > Signed-off-by: Lee, Chun-Yi <jlee@...ell.com>
> > ---
> >  drivers/gpu/Makefile       |    2 +-
> >  drivers/gpu/stub/Kconfig   |   13 +++++++++
> >  drivers/gpu/stub/Makefile  |    1 +
> >  drivers/gpu/stub/poulsbo.c |   64 ++++++++++++++++++++++++++++++++++++++++++++
> >  drivers/video/Kconfig      |    2 +
> >  5 files changed, 81 insertions(+), 1 deletions(-)
> >  create mode 100644 drivers/gpu/stub/Kconfig
> >  create mode 100644 drivers/gpu/stub/Makefile
> >  create mode 100644 drivers/gpu/stub/poulsbo.c
> > 
> > diff --git a/drivers/gpu/Makefile b/drivers/gpu/Makefile
> > index 30879df..cc92778 100644
> > --- a/drivers/gpu/Makefile
> > +++ b/drivers/gpu/Makefile
> > @@ -1 +1 @@
> > -obj-y			+= drm/ vga/
> > +obj-y			+= drm/ vga/ stub/
> > diff --git a/drivers/gpu/stub/Kconfig b/drivers/gpu/stub/Kconfig
> > new file mode 100644
> > index 0000000..c564140
> > --- /dev/null
> > +++ b/drivers/gpu/stub/Kconfig
> > @@ -0,0 +1,13 @@
> > +config STUB_POULSBO
> > +	tristate "Intel Poulsbo Stub Driver"
> > +        default m
> 
> Drop the "default m".
> 

Thank's! Will drop "default m".

> > +        # Poulsbo stub depends on ACPI_VIDEO when ACPI is enabled
> > +        # but for select to work, need to select ACPI_VIDEO's dependencies, ick
> > +        select ACPI_VIDEO if ACPI
> 
> What does it do when ACPI is not enabled?  Does the driver even build
> when APCI is not enabled?  (given the acpi_video* calls in it)
> 

This driver will not do anything if API is not enabled. It only call
acpi_video_register/acpi_video_unregister, and acpi/video.h handle it
like the following:

#if (defined CONFIG_ACPI_VIDEO || defined CONFIG_ACPI_VIDEO_MODULE)
extern int acpi_video_register(void);
extern void acpi_video_unregister(void);
extern int acpi_video_get_edid(struct acpi_device *device, int type,
                               int device_id, void **edid);
#else
static inline int acpi_video_register(void) { return 0; }
static inline void acpi_video_unregister(void) { return; }
static inline int acpi_video_get_edid(struct acpi_device *device, int
type,
                                      int device_id, void **edid)
{
        return -ENODEV;
}
#endif

So, I think don't need add "depends on ACPI_VIDEO". How do you think?

> It also has pci_* calls in it, so it looks like it needs to depend
> on PCI && ACPI, or at least on PCI.
> 
> 
Yes, thank's for your review, I will add:
	depends on PCI


Thank's a lot!
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/