linux-kernel - Re: [PATCH] Add Intel Poulsbo Stub Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <4C8A4668020000230002021A@novprvlin0050.provo.novell.com>
Date:	Thu, 09 Sep 2010 22:53:28 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<gregkh@...e.de>
Cc:	<mjg@...hat.com>, <mjg59@...f.ucam.org>, <trenn@...e.de>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<Dennis.Jansen@....de>
Subject: Re: [PATCH] Add Intel Poulsbo Stub Driver

Hi Greg, 

於 三，2010-09-01 於 08:00 -0700，Greg KH 提到：
> On Wed, Sep 01, 2010 at 05:08:39PM +0800, Lee, Chun-Yi wrote:
> > +static struct pci_device_id pciidlist[] = {
> > +	{0x8086, 0x8108, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8108}, \
> > +	{0x8086, 0x8109, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PSB_8109}, \
> > +	{0, 0, 0}
> > +};
> 
> Now that you have this, just use:
> 	MODULE_DEVICE_TABLE(pci, pciidlist);
> instead of:
> 
> > +MODULE_ALIAS("pci:v00008086d00008108sv*sd*bc*sc*i*");
> > +MODULE_ALIAS("pci:v00008086d00008109sv*sd*bc*sc*i*");
> 
> As the proper alias will automatically get generated from the
> MODULE_DEVICE_TABLE() macro.
> 

Thank's for your review and kindly suggestion.
It's useful to me! :-)

And it works fine on my Poulsbo machine, I will use:
	MODULE_DEVICE_TABLE(pci, pciidlist);


Thank's a lot!
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/