linux-kernel - [RFC PATCH] x86: don't compile with gcc-3.3.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1284366708-30154-1-git-send-email-florian@mickler.org>
Date:	Mon, 13 Sep 2010 10:31:47 +0200
From:	florian@...kler.org
To:	x86@...nel.org
Cc:	Florian Mickler <florian@...kler.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Russell King <linux@....linux.org.uk>,
	Mike Frysinger <vapier@...too.org>,
	linux-kernel@...r.kernel.org
Subject: [RFC PATCH] x86: don't compile with gcc-3.3.3

hpa commented on bug 16506[1] :
"Please note that gcc-3.3.3 is known broken on x86; gcc-3.4 is the oldest
version which is known to *not* be broken."

References: 
	[0]: https://bugzilla.kernel.org/show_bug.cgi?id=16633
	[1]: https://bugzilla.kernel.org/show_bug.cgi?id=16506#c28

If that is indeed so, we should abort the build? No?


---
 arch/x86/Makefile |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 8aa1b59..1eb2d99 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -153,7 +153,7 @@ all: bzImage
 # KBUILD_IMAGE specify target image being built
 KBUILD_IMAGE := $(boot)/bzImage
 
-bzImage: vmlinux
+bzImage: checkgccversion vmlinux
 ifeq ($(CONFIG_X86_DECODER_SELFTEST),y)
 	$(Q)$(MAKE) $(build)=arch/x86/tools posttest
 endif
@@ -172,6 +172,12 @@ PHONY += vdso_install
 vdso_install:
 	$(Q)$(MAKE) $(build)=arch/x86/vdso $@
 
+checkgccversion:
+	$(Q)if test "$(call cc-fullversion)" = "040403" ; then \
+		echo "*** GCC-3.3.3 is known broken. Please upgrade." ; \
+		echo "*** GCC-3.4 is the earliest version known *not* broken." ; \
+		false ; \
+	fi
 archclean:
 	$(Q)rm -rf $(objtree)/arch/i386
 	$(Q)rm -rf $(objtree)/arch/x86_64
-- 
1.7.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/