linux-kernel - Re: [34-stable regression] USB delay init quirk causes device events loss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1009131014460.1584-100000@iolanthe.rowland.org>
Date:	Mon, 13 Sep 2010 10:16:51 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Jiri Slaby <jslaby@...e.cz>
cc:	phil@...m.com, <stable@...nel.org>, Greg KH <gregkh@...e.de>,
	USB list <linux-usb@...r.kernel.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [34-stable regression] USB delay init quirk causes device events
 loss

On Mon, 13 Sep 2010, Jiri Slaby wrote:

> Hi,
> 
> this commit:
> commit 93362a875fc69881ae69299efaf19a55a1f57db0
> Author: Phil Dibowitz <phil@...m.com>
> Date:   Thu Jul 22 00:05:01 2010 +0200
> 
>     USB delay init quirk for logitech Harmony 700-series devices
> 
> causes a lot of pain for users who loose events from their input devices:
> https://bugzilla.novell.com/show_bug.cgi?id=638200
> 
> opensuse 11.3 uses 2.6.34 stable and that's how the patch got there.
> Reverting it makes it work again.
> 
> The problem is that the patch shuffles with usb_detect_quirks which used
> to disable autosuspend by default. Apparently it no longer does.

I don't see how that patch could have the effect you claim.  
usb_detect_quirks still calls usb_disable_autosuspend.  Can you do a 
little more debugging to find out why it isn't working as expected?  
Reverting the commit is not a good solution.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/