linux-kernel - Re: [34-stable regression] USB delay init quirk causes device events loss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C8E33CE.4010105@suse.cz>
Date:	Mon, 13 Sep 2010 16:23:10 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	phil@...m.com, stable@...nel.org, Greg KH <gregkh@...e.de>,
	USB list <linux-usb@...r.kernel.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [34-stable regression] USB delay init quirk causes device events
 loss

On 09/13/2010 04:16 PM, Alan Stern wrote:
> On Mon, 13 Sep 2010, Jiri Slaby wrote:
>> The problem is that the patch shuffles with usb_detect_quirks which used
>> to disable autosuspend by default. Apparently it no longer does.
> 
> I don't see how that patch could have the effect you claim.  
> usb_detect_quirks still calls usb_disable_autosuspend.  Can you do a 
> little more debugging to find out why it isn't working as expected?  
> Reverting the commit is not a good solution.

Ok, I could, but I have a near-zero knowledge about usb core stuff. What
I see is that usb_detect_quirks moved from usb_new_device to
hub_port_connect_change. Might that be that there are broken devices
which doesn't generate state changes properly?

In other words, what I could do is to add some printks into
hub_port_connect_change if that's called at all. If you need some
thorough debugging printks, please send me a patch to test instead.

thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/