linux-kernel - Re: [34-stable regression] USB delay init quirk causes device events loss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1009131045000.1584-100000@iolanthe.rowland.org>
Date:	Mon, 13 Sep 2010 10:48:17 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Jiri Slaby <jslaby@...e.cz>
cc:	phil@...m.com, <stable@...nel.org>, Greg KH <gregkh@...e.de>,
	USB list <linux-usb@...r.kernel.org>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [34-stable regression] USB delay init quirk causes device events
 loss

On Mon, 13 Sep 2010, Jiri Slaby wrote:

> On 09/13/2010 04:16 PM, Alan Stern wrote:
> > On Mon, 13 Sep 2010, Jiri Slaby wrote:
> >> The problem is that the patch shuffles with usb_detect_quirks which used
> >> to disable autosuspend by default. Apparently it no longer does.
> > 
> > I don't see how that patch could have the effect you claim.  
> > usb_detect_quirks still calls usb_disable_autosuspend.  Can you do a 
> > little more debugging to find out why it isn't working as expected?  
> > Reverting the commit is not a good solution.
> 
> Ok, I could, but I have a near-zero knowledge about usb core stuff. What
> I see is that usb_detect_quirks moved from usb_new_device to
> hub_port_connect_change. Might that be that there are broken devices
> which doesn't generate state changes properly?

No, that's not possible.  That state change comes from the device's 
parent hub; without it we wouldn't know that the device was plugged 
in at all.

> In other words, what I could do is to add some printks into
> hub_port_connect_change if that's called at all. If you need some
> thorough debugging printks, please send me a patch to test instead.

Hmm.  I'd prefer to explain how it's all supposed to work and let you
figure out where best to look.  Or try to debug it myself.  Does this
happen with other sorts of USB devices as well, or just wacom?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/