linux-kernel - Re: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only if data is transfered over

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Sep 2010 20:26:52 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
CC:	Ming Lei <tom.leiming@...il.com>, greg@...ah.com,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Felipe Balbi <balbi@...com>, Anand Gadiyar <gadiyar@...com>,
	Mike Frysinger <vapier@...too.org>
Subject: Re: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only if
 data is transfered over

Hello.

I wrote:

>>>   But why not modify the conditional above all that code, just excluding
>>> 'is_dma' from it. This conditional already includes (request->actual ==
>>> request->length) check. Please recast this patch.

>> The two condition is OR relation, not and, so we can't exclude 
>> 'is_dma' simply.

>    Yes, we can. You're clearly handling only the DMA case with your 
> added check, the PIO case was already handled.

>> Anyway, the change is not wrong, right?

>    Not wrong, but the check is duplicate.

    Oops, I've been too fast and haven't realized that the check done here _is_ 
actually wrong. It causes ZLP send to trigger too fast in the DMA case. So 
please fix this patch. Felipe, please drop it for now.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/