linux-kernel - Re: [PATCH 1/2] SLUB: Fix merged slab cache names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1009141244330.444@router.home>
Date:	Tue, 14 Sep 2010 12:47:10 -0500 (CDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Pekka Enberg <penberg@...nel.org>
cc:	torvalds@...ux-founation.org, linux-kernel@...r.kernel.org,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH 1/2] SLUB: Fix merged slab cache names

On Tue, 14 Sep 2010, Pekka Enberg wrote:

> > Put this into mm/slub.c as slub only flag? What is the difference from
> > refcount == 1?
> I can put it in mm/slub.c but I was worried about someone reusing the bit for
> something else.

Allocate from the other end like __OBJECT_POISON.

> Do you mean refcount == 2? You don't know during kmem cache release time if
> someone was merged to the cache or not.

> > Ok. Keeping the original name. Why dont we do strdup by default and always
> > do a kfree(s->name) on close?
> >
> I tried that. It gets very nasty during bootstrap.

Add it only to kmem_cache_create() not to kmem_cache_open. That is not
used during bootstrap. The bootstrap caches do not matter since they are
never freed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/