linux-kernel - Re: [lm-sensors] [PATCH] hwmon/emc1403: remove unnecessary hwmon_device_unregister

Open Source and information security mailing list archives

Message-ID: <20100914032211.GA3497@ericsson.com>
Date:	Mon, 13 Sep 2010 20:22:11 -0700
From:	Guenter Roeck <guenter.roeck@...csson.com>
To:	Yong Wang <yong.y.wang@...ux.intel.com>
CC:	Jean Delvare <khali@...ux-fr.org>, Alan Cox <alan@...ux.intel.com>,
	Kalhan Trisal <kalhan.trisal@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lm-sensors@...sensors.org" <lm-sensors@...sensors.org>
Subject: Re: [lm-sensors] [PATCH] hwmon/emc1403: remove unnecessary
 hwmon_device_unregister

On Mon, Sep 13, 2010 at 10:33:51PM -0400, Yong Wang wrote:
> It is unnecessary to call hwmon_device_unregister in error handling
> before hwmon_device_register is called.
> 
Not only unnecessary but wrong. Good catch.

> Signed-off-by: Yong Wang <yong.y.wang@...el.com>

Reviewed-by: Guenter Roeck <guenter.roeck@...csson.com>

> ---
>  drivers/hwmon/emc1403.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c
> index 5b58b20..8dee3f3 100644
> --- a/drivers/hwmon/emc1403.c
> +++ b/drivers/hwmon/emc1403.c
> @@ -308,7 +308,6 @@ static int emc1403_probe(struct i2c_client *client,
>  	res = sysfs_create_group(&client->dev.kobj, &m_thermal_gr);
>  	if (res) {
>  		dev_warn(&client->dev, "create group failed\n");
> -		hwmon_device_unregister(data->hwmon_dev);
>  		goto thermal_error1;
>  	}
>  	data->hwmon_dev = hwmon_device_register(&client->dev);
> -- 
> 1.5.5.1
> 
> 
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@...sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives