linux-kernel - Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Sep 2010 11:52:30 +0900
From:	"Tomoya MORINAGA" <morinaga526@....okisemi.com>
To:	"Grant Likely" <grant.likely@...retlab.ca>,
	"Linus Walleij" <linus.ml.walleij@...il.com>
Cc:	"Masayuki Ohtake" <masa-korg@....okisemi.com>,
	<meego-dev@...go.com>, "LKML" <linux-kernel@...r.kernel.org>,
	"David Brownell" <dbrownell@...rs.sourceforge.net>,
	<qi.wang@...el.com>, <yong.y.wang@...el.com>,
	<andrew.chih.howe.khor@...el.com>, <arjan@...ux.intel.com>,
	<gregkh@...e.de>, "Thomas Gleixner" <tglx@...utronix.de>,
	"David Woodhouse" <dwmw2@...radead.org>
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35

----- Original Message ----- 
From: "Grant Likely" <grant.likely@...retlab.ca>
To: "Linus Walleij" <linus.ml.walleij@...il.com>
Cc: "Masayuki Ohtake" <masa-korg@....okisemi.com>; <meego-dev@...go.com>;
"LKML" <linux-kernel@...r.kernel.org>; "David Brownell"
<dbrownell@...rs.sourceforge.net>; <qi.wang@...el.com>;
<yong.y.wang@...el.com>; <andrew.chih.howe.khor@...el.com>;
<arjan@...ux.intel.com>; <gregkh@...e.de>; "Tomoya MORINAGA"
<morinaga526@....okisemi.com>; "Thomas Gleixner" <tglx@...utronix.de>;
"David Woodhouse" <dwmw2@...radead.org>
Sent: Friday, September 10, 2010 1:55 PM
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35


> On Thu, Sep 09, 2010 at 10:58:38PM +0200, Linus Walleij wrote:
> > 2010/9/3 Masayuki Ohtake <masa-korg@....okisemi.com>:
> >
> > > Each instance of our SPI device has the same vendor ID and device ID.
> > > Thus, I think it is impossible to be called probe() for each instance.
> >
> > Looking at you latest patch it appears you could :-)
> > That solves the problem pretty nicely.
>
> Actually, it doesn't look like he did.  It looks to me that the
> ability to support multiple spi bus instances on a single PCI device
> has simply been removed.  I don't know if that is because it simply
> isn't needed yet, or if it is because Ohtake-san doesn't quite
> understand what were suggesting.

We wanted you to accept multi-instance the SPI patch.
But seeing maintainer's comments, I felt it is difficult to be accepted.
Thus, I have deleted whole of multi-instance code.

>
> Regardless it doesn't matter.  When or if the driver does need to be
> modified to support multiple instances, it is a relatively straight
> forward matter to refactor the current code into a platform_driver,
> and create a new pci_driver that simply registers the matching
> platform_device for each spi bus instance supported by the device.
>
> g.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/