linux-kernel - Re: [RESEND/PATCH 6/6] USB: musb-gadget: fix dma length in txstate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100915070936.GD3393@legolas.emea.dhcp.ti.com>
Date:	Wed, 15 Sep 2010 10:09:37 +0300
From:	Felipe Balbi <balbi@...com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	"tom.leiming@...il.com" <tom.leiming@...il.com>,
	"greg@...ah.com" <greg@...ah.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Felipe Balbi <me@...ipebalbi.com>,
	"Gadiyar, Anand" <gadiyar@...com>,
	Mike Frysinger <vapier@...too.org>
Subject: Re: [RESEND/PATCH 6/6] USB: musb-gadget: fix dma length in txstate

On Tue, Sep 14, 2010 at 12:43:25PM -0500, Sergei Shtylyov wrote:
>Hello.
>
>tom.leiming@...il.com wrote:
>
>> From: Ming Lei <tom.leiming@...il.com>
>
>> DMA length should not go beyond the availabe space of request buffer,
>> so fix it.
>
>> Signed-off-by: Ming Lei <tom.leiming@...il.com>
>> Cc: David Brownell <dbrownell@...rs.sourceforge.net>
>> Cc: Felipe Balbi <me@...ipebalbi.com>
>> Cc: Anand Gadiyar <gadiyar@...com>
>> Cc: Mike Frysinger <vapier@...too.org>
>> Cc: Sergei Shtylyov <sshtylyov@...mvista.com>
>
>[...]
>
>> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
>> index fa826f9..cacae96 100644
>> --- a/drivers/usb/musb/musb_gadget.c
>> +++ b/drivers/usb/musb/musb_gadget.c
>> @@ -300,6 +300,11 @@ static void txstate(struct musb *musb, struct musb_request *req)
>>  #ifndef	CONFIG_MUSB_PIO_ONLY
>>  	if (is_dma_capable() && musb_ep->dma) {
>>  		struct dma_controller	*c = musb->dma_controller;
>> +		size_t request_size;
>> +
>> +		/* setup DMA, then program endpoint CSR */
>> +		request_size = min_t(size_t, request->length - request->actual,
>> +					musb_ep->dma->max_len);
>
>    Er, you're moving this from under #ifdef CONFIG_USB_INVENTRA_DMA to the
>common code, right? Do you know that not all DMA drivers initialize max_len? For
>example CPPI driver doesn't, so it's left at zero. You're going to break DMA for
>CPPI. Please extend your patch, adding cppi_dma.c to it.

yes, please set some value on cppi_dma.c max_len field.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/