linux-kernel - Re: [PATCH] drivers:staging:ti-st: mv headers to ti_wilink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100916224829.GB14256@suse.de>
Date:	Thu, 16 Sep 2010 15:48:29 -0700
From:	Greg KH <gregkh@...e.de>
To:	pavan_savoy@...com
Cc:	alan@...rguk.ukuu.org.uk, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers:staging:ti-st: mv headers to ti_wilink_st

On Thu, Sep 16, 2010 at 06:34:04PM -0400, pavan_savoy@...com wrote:
> From: Pavan Savoy <pavan_savoy@...com>
> 
> move all the header information to ti_wilink_st.h.
> This header would then not only serve the local modules like the st_core.c,
> st_kim.c and st_ll.c but also the external modules/protocol drivers that are
> dependent on the shared transport driver.
> Also modify the structures to use cleaner u8/u16 types for data coming
> in from chip and data parsed out of firmware.

No!

Don't do more than one thing at once please, do one thing at a time.

One patch to modify the structures.

And one patch to move things together.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/