linux-kernel - Re: [PATCH 0/3] BDI handling fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100917125245.GA3342@quack.suse.cz>
Date:	Fri, 17 Sep 2010 14:52:45 +0200
From:	Jan Kara <jack@...e.cz>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Jan Kara <jack@...e.cz>, Jens@...e.cz, "Axboe <axboe"@kernel.dk,
	LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 0/3] BDI handling fixes

On Thu 16-09-10 19:47:42, Christoph Hellwig wrote:
> On Fri, Sep 17, 2010 at 12:44:08AM +0200, Jan Kara wrote:
> > 
> >   Hi,
> > 
> >   series of these three patches fixes the warning in __mark_inode_dirty()
> > which happens when I do e.g. touch /dev/zero. The first two patches should
> > be obvious enough and probably worth merging independently of the third
> > patch. The third patch is upto a discussion whether we want to solve the
> > problem that way or differently. Christoph, I know we spoke at LSF that
> > inode_to_bdi() could be a per-sb method but the current version of the
> > patch seems clean enough to me that we could maybe go even without the
> > special callback?
> 
> Feel free to go with the simpler one.  But what I think really needs to
> be changes is the no writeback flag - it's exactly the wrong way around.
> 
> Instead just add a flag to allow writeback for the block device and
> fs-specific bdi structures.
  Agreed. I just think that I'll first make the flags right and then just
mechanically flip NO_WRITEBACK and WRITEBACK...

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/