linux-kernel - Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100917155937.GB29596@rakim.wolfsonmicro.main>
Date:	Fri, 17 Sep 2010 16:59:37 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Nishanth Menon <nm@...com>
Cc:	linux-arm <linux-arm-kernel@...ts.infradead.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Phil Carmody <ext-phil.2.carmody@...ia.com>,
	linux-doc <linux-doc@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	"Chikkature Rajashekar, Madhusudhan" <madhu.cr@...com>,
	"Aguirre, Sergio" <saaguirre@...com>,
	Andi Kleen <ak@...ux.intel.com>,
	linux-pm <linux-pm@...ts.linux-foundation.org>,
	Matthew Garrett <mjg@...hat.com>,
	Len Brown <len.brown@...el.com>,
	Eduardo Valentin <eduardo.valentin@...ia.com>,
	linux-omap <linux-omap@...r.kernel.org>,
	"Gopinath, Thara" <thara@...com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	"Granados Dorado, Roberto" <x0095451@...com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Romit Dasgupta <ro.mit@...com>,
	Tero Kristo <Tero.Kristo@...ia.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Premi, Sanjeev" <premi@...com>
Subject: Re: [linux-pm] [PATCH] opp: introduce library for device-specific
 OPPs

On Fri, Sep 17, 2010 at 10:53:06AM -0500, Nishanth Menon wrote:
> Mark Brown had written, on 09/17/2010 10:36 AM, the following:

> >It might be clearer to use some term other than enabled in the code -
> >when reading I wasn't immediately sure if enabled meant that it was
> >available to be selected or if it was the active operating point.  How
> >about 'allowed' (though I'm not 100% happy with that)?

> ;).. The opp is enabled or disabled if it is populated, it is
> implicit as being available but not enabled- how about active? this
> would change the opp_enable/disable functions to opp_activate,
> opp_deactivate..

> Recommendations folks?

The enable/disable thing wasn't so noticable in the API itself, it was
in the data structures that I found it confusing - the core has a
different idea about what's going on with the system as a whole compared
to the decision that an individual device is taking.

> >When reading the description I'd expected to see some facility to
> >trigger selection of an active operating point in the library (possibly
> >as a separate call since you might have a bunch of operating points
> >being updated in quick succession) but it looks like that needs to be
> >supplied externally at the minute?

> The intent is we use the opp_search* functions to pick up the opp
> and enable/activate it and disable/deactivate it.

Sure, I get that bit.  What I meant was that I was expecting something
that would say that changes had been made to the enabled/disabled sets
and that it'd be a good idea to rescan, especially for cases where the
devices change their requirements but the OPPs need to be done over a
larger block.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/