linux-kernel - Re: [linux-pm] [PATCH] opp: introduce library for device-specific OPPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100917164543.GI20325@esdhcp04044.research.nokia.com>
Date:	Fri, 17 Sep 2010 19:45:43 +0300
From:	Phil Carmody <ext-phil.2.carmody@...ia.com>
To:	ext Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Nishanth Menon <nm@...com>,
	linux-arm <linux-arm-kernel@...ts.infradead.org>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-doc <linux-doc@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Madhusudhan Chikkature Rajashekar <madhu.cr@...com>,
	Sergio Alberto Aguirre Rodriguez <saaguirre@...com>,
	Andi Kleen <ak@...ux.intel.com>,
	linux-pm <linux-pm@...ts.linux-foundation.org>,
	Matthew Garrett <mjg@...hat.com>,
	Len Brown <len.brown@...el.com>,
	"Valentin Eduardo (Nokia-MS/Helsinki)" <eduardo.valentin@...ia.com>,
	linux-omap <linux-omap@...r.kernel.org>,
	Thara Gopinath <thara@...com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Roberto Granados Dorado <x0095451@...com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Romit Dasgupta <ro.mit@...com>,
	"Kristo Tero (Nokia-MS/Tampere)" <Tero.Kristo@...ia.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sanjeev Premi <premi@...com>
Subject: Re: [linux-pm] [PATCH] opp: introduce library for device-specific
	OPPs

On 17/09/10 17:36 +0200, ext Mark Brown wrote:
> On Thu, Sep 16, 2010 at 08:29:33PM -0500, Nishanth Menon wrote:
> 
> > +struct opp_def {
> > +	unsigned long freq;
> > +	unsigned long u_volt;
> > +
> > +	bool enabled;
> > +};
> 
> It might be clearer to use some term other than enabled in the code -
> when reading I wasn't immediately sure if enabled meant that it was
> available to be selected or if it was the active operating point.  How
  ^^^^^^^^^
> about 'allowed' (though I'm not 100% happy with that)?

I think your query contains its own answer.

Phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/