linux-kernel - Re: [PATCH] staging: brcm80211: add fullmac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 20 Sep 2010 20:54:35 -0700
From:	Greg KH <greg@...ah.com>
To:	Nohee Ko <noheek@...adcom.com>
Cc:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Roman Baker <romanb@...adcom.com>,
	David Milne <davidm@...adcom.com>,
	Venkat Rao <vrao@...adcom.com>,
	Howard Harte <hharte@...adcom.com>,
	Brett Rudley <brudley@...adcom.com>,
	Henry Ptasinski <henryp@...adcom.com>
Subject: Re: [PATCH] staging: brcm80211: add fullmac driver

On Mon, Sep 20, 2010 at 07:43:22PM -0700, Nohee Ko wrote:
> This patch to the existing bcm80211 directory in the staging tree adds fullmac driver support for the BCM4329 SDIO chip from Broadcom. Configuration of the mac80211 driver or the fullmac driver can be done through menuconfig.

Please wrap your lines at 72 columns.

Your patch does not apply to the latest linux-next tree.  Your patch is
also mime-encoded which probably doesn't help things.

Care to fix this up and resend it so I can apply it?

> --- a/drivers/staging/brcm80211/util/siutils.c
> +++ b/drivers/staging/brcm80211/util/siutils.c
> @@ -59,12 +59,16 @@ static bool si_buscore_prep(si_info_t *sii, uint bustype, uint devid,
>                             void *sdh);
>  static bool si_buscore_setup(si_info_t *sii, chipcregs_t *cc, uint bustype,
>                              uint32 savewin, uint *origidx, void *regs);
> +#ifndef BRCM_FULLMAC
>  static void si_nvram_process(si_info_t *sii, char *pvars);
> +#endif
> 
>  /* dev path concatenation util */
> +#ifndef BRCM_FULLMAC

<snip>

Why all the #ifdef mess added to the siutils.c file?  Is it really
needed?  Why not just leave it alone and have the functions always
build.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/