linux-kernel - Re: [PATCH] kmemleak: add unlikely() optimization to kmemleak_late

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tnxlj6uhz2s.fsf@e102109-lin.cambridge.arm.com>
Date:	Wed, 22 Sep 2010 11:06:35 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	dave@....org
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kmemleak: add unlikely() optimization to kmemleak_late_init

Davidlohr Bueso <dave@....org> wrote:
> kmemleak: add unlikely() optimization to kmemleak_late_init()
>
> Since there it is not very probable that kmemleak_disable() was called right after setting kmemleak_initialized, we could benefit from predicting it.

The patch is correct and you can add my Acked-by but I don't really
think it's worth. We save ~2 cycles during booting, no-one would ever
notice.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/