linux-kernel - Re: [PATCH] kmemleak: add unlikely() optimization to kmemleak_late

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1285250712.2127.1.camel@cowboy>
Date:	Thu, 23 Sep 2010 10:05:12 -0400
From:	Davidlohr Bueso <dave@....org>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kmemleak: add unlikely() optimization to
 kmemleak_late_init

On Wed, 2010-09-22 at 11:06 +0100, Catalin Marinas wrote:
> Davidlohr Bueso <dave@....org> wrote:
> > kmemleak: add unlikely() optimization to kmemleak_late_init()
> >
> > Since there it is not very probable that kmemleak_disable() was called right after setting kmemleak_initialized, we could benefit from predicting it.
> 
> The patch is correct and you can add my Acked-by but I don't really
> think it's worth. We save ~2 cycles during booting, no-one would ever
> notice.
> 

Yeah, it's not a big performance booster, but IMHO it wouldn't hurt to
add it. Since you are the maintainer it's up to you if you include it
upstream.

Thanks,
Davidlohr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/