linux-kernel - Re: [PATCH] perf build fixes for opensuse 10.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimqTva4gYncxzeMokT19rYqZ4kj5p=jONYXmP7Q@mail.gmail.com>
Date:	Wed, 22 Sep 2010 15:10:04 +0200
From:	John Kacur <jkacur@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	acme@...hat.com, a.p.zijlstra@...llo.nl, mingo@...e.hu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf build fixes for opensuse 10.0

On Wed, Sep 22, 2010 at 1:15 PM, Andi Kleen <andi@...stfloor.org> wrote:
>> On Wed, Sep 22, 2010 at 11:03 AM, Andi Kleen <andi@...stfloor.org> wrote:
>>> Fix the perf Makefile to compile on opensuse 10.0
>>>
>>> -Werror in shipping code is usually a bad idea. Remove that.
>>
>> Why not remove it then when you ship the code, but leave it in the kernel
>> where it is useful?
>
> What do you mean with "you ship"?

The subject of your email is "perf build fixes for opensuse 10.0"
So, I inferred from there.

> I downloaded a kernel from kernel.org, it shipped to me and didn't
> build.

Any reason you can't fix the build errors instead?
Btw, I just tried building the lastest perf in tip/master
and I had no problems.

>
> People can enable -Werror in their private source dirs, but
> it shouldn't be in any downloadable tarball or git.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/