[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100922132509.GD5766@basil.fritz.box>
Date: Wed, 22 Sep 2010 15:25:09 +0200
From: Andi Kleen <andi@...stfloor.org>
To: John Kacur <jkacur@...hat.com>
Cc: Andi Kleen <andi@...stfloor.org>, acme@...hat.com,
a.p.zijlstra@...llo.nl, mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf build fixes for opensuse 10.0
On Wed, Sep 22, 2010 at 03:10:04PM +0200, John Kacur wrote:
> On Wed, Sep 22, 2010 at 1:15 PM, Andi Kleen <andi@...stfloor.org> wrote:
> >> On Wed, Sep 22, 2010 at 11:03 AM, Andi Kleen <andi@...stfloor.org> wrote:
> >>> Fix the perf Makefile to compile on opensuse 10.0
> >>>
> >>> -Werror in shipping code is usually a bad idea. Remove that.
> >>
> >> Why not remove it then when you ship the code, but leave it in the kernel
> >> where it is useful?
> >
> > What do you mean with "you ship"?
>
> The subject of your email is "perf build fixes for opensuse 10.0"
> So, I inferred from there.
You inferred wrong. That was just using it on opensuse 10.0
(opensuse 10.0 has already shipped a very long time ago, it's really
old by now)
>
> > I downloaded a kernel from kernel.org, it shipped to me and didn't
> > build.
>
> Any reason you can't fix the build errors instead?
That's what I did -- and then sent the patch.
> Btw, I just tried building the lastest perf in tip/master
> and I had no problems.
Because you're not using opensuse 10.0
-Andi
--
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists