linux-kernel - Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 25 Sep 2010 22:37:52 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Huang Ying <ying.huang@...el.com>
Cc:	Chen Gong <gong.chen@...ux.intel.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH]  PCI / PCIe / AER ...)

On Saturday, September 25, 2010, Huang Ying wrote:
> Hi, Rafael,
> 
> On Tue, 2010-09-21 at 00:50 +0800, Rafael J. Wysocki wrote:
> > --- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
> > +++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
> > @@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev 
> >  		| OSC_PCI_EXPRESS_PME_CONTROL;
> >  
> >  	if (pci_aer_available()) {
> > -		if (pcie_aer_get_firmware_first(port))
> > +		if (aer_acpi_firmware_first())
> >  			dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
> >  		else
> >  			flags |= OSC_PCI_EXPRESS_AER_CONTROL;
> 
> The original per-device firmware_first is overridden by the new global
> firmware_first? If it is, why keep the original per-device
> firmware_first?

I didn't want to remove it just yet, but I do think it should be removed.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/