lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Sep 2010 10:39:40 +0200 From: Pablo Neira Ayuso <pablo@...filter.org> To: Eric Paris <eparis@...hat.com> CC: linux-kernel@...r.kernel.org, selinux@...ho.nsa.gov, netfilter-devel@...r.kernel.org, jmorris@...ei.org, sds@...ho.nsa.gov, jengelh@...ozas.de, paul.moore@...com, casey@...aufler-ca.com, linux-security-module@...r.kernel.org, netfilter@...r.kernel.org, mr.dash.four@...glemail.com Subject: Re: [PATCH 2/6] secmark: make secmark object handling generic On 24/09/10 22:45, Eric Paris wrote: > Right now secmark has lots of direct selinux calls. Use all LSM calls and > remove all SELinux specific knowledge. The only SELinux specific knowledge > we leave is the mode. The only point is to make sure that other LSMs at > least test this generic code before they assume it works. (They may also > have to make changes if they do not represent labels as strings) > > Signed-off-by: Eric Paris <eparis@...hat.com> > --- > > include/linux/netfilter/xt_SECMARK.h | 14 ++------ > include/linux/security.h | 25 +++++++++++++ > include/linux/selinux.h | 63 ---------------------------------- > net/netfilter/xt_CT.c | 1 - > net/netfilter/xt_SECMARK.c | 57 +++++++++++++++---------------- > security/capability.c | 17 +++++++++ > security/security.c | 18 ++++++++++ > security/selinux/exports.c | 49 -------------------------- > security/selinux/hooks.c | 24 +++++++++++++ > security/selinux/include/security.h | 1 + > 10 files changed, 116 insertions(+), 153 deletions(-) > > diff --git a/include/linux/netfilter/xt_SECMARK.h b/include/linux/netfilter/xt_SECMARK.h > index 6fcd344..b8d55c4 100644 > --- a/include/linux/netfilter/xt_SECMARK.h > +++ b/include/linux/netfilter/xt_SECMARK.h > @@ -10,19 +10,13 @@ > * 'mode' refers to the specific security subsystem which the > * packets are being marked for. > */ > -#define SECMARK_MODE_SEL 0x01 /* SELinux */ > -#define SECMARK_SELCTX_MAX 256 > - > -struct xt_secmark_target_selinux_info { > - __u32 selsid; > - char selctx[SECMARK_SELCTX_MAX]; > -}; > +#define SECMARK_MODE_SELINUX 0x01 /* SELinux */ > +#define SECMARK_SECCTX_MAX 256 The SECMARK_MODE_SEL is exposed to user-space, even if we have a copy of it in the internal iptables tree, I'm not sure if it's a good policy to change it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists