linux-kernel - Re: [PATCH v2] olpc_battery: Fix endian neutral breakage for s16 values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CA0AF77.1080105@laptop.org>
Date:	Mon, 27 Sep 2010 10:51:35 -0400
From:	"Richard A. Smith" <richard@...top.org>
To:	Daniel Drake <dsd@...top.org>
CC:	cbou@...l.ru, dwmw2@...radead.org, dilinger@...ued.net,
	linux-kernel@...r.kernel.org, harvey.harrison@...il.com
Subject: Re: [PATCH v2] olpc_battery: Fix endian neutral breakage for s16
 values

On 09/25/2010 02:19 PM, Daniel Drake wrote:
> From: Richard A. Smith<richard@...top.org>
>
> When the driver was updated to be endian neutral (8e9c7716c)
> the signed part of the s16 values was lost.  This is because be16_to_cpu()
> returns a signed value.  This patch casts the values back to a s16 number
> prior to the the implicit cast up to an int.

Seems the comment has a error.  Should be 'returns an unsigned' rather 
than signed.  Other than that it looks good.

-- 
Richard A. Smith  <richard@...top.org>
One Laptop per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/