linux-kernel - Re: [PATCH v2] olpc_battery: Fix endian neutral breakage for s16 values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100928111607.GA22734@oksana.dev.rtsoft.ru>
Date:	Tue, 28 Sep 2010 15:16:07 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	"Richard A. Smith" <richard@...top.org>
Cc:	Daniel Drake <dsd@...top.org>, dwmw2@...radead.org,
	dilinger@...ued.net, linux-kernel@...r.kernel.org,
	harvey.harrison@...il.com
Subject: Re: [PATCH v2] olpc_battery: Fix endian neutral breakage for s16
 values

On Mon, Sep 27, 2010 at 10:51:35AM -0400, Richard A. Smith wrote:
> On 09/25/2010 02:19 PM, Daniel Drake wrote:
> >From: Richard A. Smith<richard@...top.org>
> >
> >When the driver was updated to be endian neutral (8e9c7716c)
> >the signed part of the s16 values was lost.  This is because be16_to_cpu()
> >returns a signed value.  This patch casts the values back to a s16 number
> >prior to the the implicit cast up to an int.
> 
> Seems the comment has a error.  Should be 'returns an unsigned'
> rather than signed.  Other than that it looks good.

Fixed and applied w/ Cc: <stable@...nel.org>, thanks!

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/