linux-kernel - Re: [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CA20158.5040700@stericsson.com>
Date:	Tue, 28 Sep 2010 16:53:12 +0200
From:	Linus Walleij <linus.walleij@...ricsson.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"yuanyabin1978@...a.com" <yuanyabin1978@...a.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10

Dan Williams wrote:
> [Me]
>> As mentioned I have no clue to why this failed to compile for Grant,
>> please see if this tenth version is still problematic or if it was
>> something intermittent.
>>
>> Else I really need help in knowing what config to compile, this was
>> compiled for U300, U8500 and RealView with and without DMA enabled.
> 
> Maybe it makes more sense for these filter_id functions to be defined
> in the arch code rather than the dma driver.  Right now there seems to
> be a weird dependency of arch requires dma-driver, dma-driver requires
> arch, and slave-driver requires arch and dma-driver in order to
> dynamically select dma-driver with dma_request_channel().  It forces
> dma-driver and slave-driver to always be compiled in, if I am reading
> this correctly.

I think what happened was two things:

- First that I was switching on CONFIG_DMADEVICES rather than
  CONFIG_DMA_ENGINE which caused the immediate compile warnings

- Second I had no dummy filter function for COH901318 and ste_dma40
  in case the driver was not compiled in or available as
  module.

I actually think it is OK to request that DMA drivers always be
compiled in for slave transfer support, they are *really* infrastructure
IMO.

And that is why "my" drivers are Kconfig:ed bool.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/