linux-kernel - Re: [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinoGjwWjqHQx-+UB+9K+s97t9c0y5i5-rdw=UA4@mail.gmail.com>
Date:	Thu, 23 Sep 2010 14:31:22 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	linux-arm-kernel@...ts.infradead.org, yuanyabin1978@...a.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] ARM: add PrimeCell generic DMA to PL022 v10

On Wed, Sep 1, 2010 at 8:24 AM, Linus Walleij
<linus.walleij@...ricsson.com> wrote:
> This extends the PL022 SSP/SPI driver with generic DMA engine
> support using the PrimeCell DMA engine interface. Also fix up the
> test code for the U300 platform.
>
> Acked-by: Grant Likely <grant.likely@...retlab.ca>
> Signed-off-by: Linus Walleij <linus.walleij@...ricsson.com>
> ---
> As mentioned I have no clue to why this failed to compile for Grant,
> please see if this tenth version is still problematic or if it was
> something intermittent.
>
> Else I really need help in knowing what config to compile, this was
> compiled for U300, U8500 and RealView with and without DMA enabled.

Maybe it makes more sense for these filter_id functions to be defined
in the arch code rather than the dma driver.  Right now there seems to
be a weird dependency of arch requires dma-driver, dma-driver requires
arch, and slave-driver requires arch and dma-driver in order to
dynamically select dma-driver with dma_request_channel().  It forces
dma-driver and slave-driver to always be compiled in, if I am reading
this correctly.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/