linux-kernel - Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100928162839.GA10739@opensource.wolfsonmicro.com>
Date:	Tue, 28 Sep 2010 09:28:40 -0700
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Masayuki Ohtake <masa-korg@....okisemi.com>
Cc:	Mike Frysinger <vapier@...too.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Alek Du <alek.du@...el.com>, richard.rojfors@...ean-labs.com,
	meego-dev@...go.com,
	ML linux-kernel <linux-kernel@...r.kernel.org>,
	Qi <qi.wang@...el.com>, andrew.chih.howe.khor@...el.com,
	gregkh@...e.de, Yong Y <yong.y.wang@...el.com>,
	Tomoya MORINAGA <morinaga526@....okisemi.com>,
	joel.clark@...el.com, margie.foster@...el.com,
	kok.howg.ewe@...el.com
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_GPIO driver to 2.6.35

On Tue, Sep 28, 2010 at 03:35:39PM +0900, Masayuki Ohtake wrote:

>     gpio->base = (u32)chip->pch_gpio_base_address;

This is the number that will be assigned to the first GPIO if the chip
registers successfully.

>     gpio->ngpio = 12;

This is the number of GPIOs your chip has.

>     chip->pch_gpio_base_address = pci_iomap(pdev, 1, 0);

This initialisation is incorrect and is likely to fail.  gpiolib knows
nothing of how your chip is controlled, the base is the base for the
GPIO numbers used to access GPIOs in gpiolib.  Please refer to other
gpiolib drivers for examples of how to use the gpilib APIs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/