linux-kernel - RE: [RFC trollpatch 1/1] genirq: Remove the fits all and nothing __do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <987664A83D2D224EAE907B061CE93D530160554808@orsmsx505.amr.corp.intel.com>
Date:	Tue, 28 Sep 2010 21:55:01 -0700
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Kyle McMartin <kyle@...artin.ca>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Christoph Hellwig <hch@...radead.org>,
	"linux-alpha@...r.kernel.org" <linux-alpha@...r.kernel.org>,
	"linux-cris-kernel@...s.com" <linux-cris-kernel@...s.com>,
	"linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Hirokazu Takata <takata@...ux-m32r.org>,
	Greg Ungerer <gerg@...inux.org>, Jeff Dike <jdike@...toit.com>,
	"linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>,
	Chris Zankel <chris@...kel.net>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>
Subject: RE: [RFC trollpatch 1/1] genirq: Remove the fits all and nothing
 __do_IRQ() code

> Did you end up solving this? ia64 iosapic and parisc iosapic still look
> fairly similar... I hit the same issue of ->end() not being called in
> the handle_level_irq path and ended up just folding in the missing bit
> to ->unmask (we were already EOI the IOSAPIC, but missing the EOI for
> the parisc cpu.)

Kyle,

Yes. Take a look in today's linux-next kernel (tag next-20100929)
for commit: 5d4bff94f9e0877a85b4dc573eb7a3f1d97c13ae

Essentially I just added an "unmask_irq()" call into the ->end
routine, renamed it, and used it as ->unmask.

It seems to work okay - I tried migrating interrupts around by
poking at /proc/irq/NNN/smp_affinity - and that still works.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/