linux-kernel - Re: [PATCH 1/2] autofs: Only declare function when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Sep 2010 22:00:33 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Márton Németh <nm127@...email.hu>,
	"H. Peter Anvin" <hpa@...or.com>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/2] autofs: Only declare function when CONFIG_COMPAT is defined

On Fri, Sep 24, 2010 at 15:22, Frederic Weisbecker <fweisbec@...il.com> wrote:
> From: Márton Németh <nm127@...email.hu>
>
> The patch solves the following warnings message when CONFIG_COMPAT
> is not defined:
>
> fs/autofs/root.c:30: warning: ‘autofs_root_compat_ioctl’ declared ‘static’ but never defined
>
> Signed-off-by: Márton Németh <nm127@...email.hu>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>
> ---
>  fs/autofs/root.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/autofs/root.c b/fs/autofs/root.c
> index 11b1ea7..0c4ca81 100644
> --- a/fs/autofs/root.c
> +++ b/fs/autofs/root.c
> @@ -27,7 +27,9 @@ static int autofs_root_unlink(struct inode *,struct dentry *);
>  static int autofs_root_rmdir(struct inode *,struct dentry *);
>  static int autofs_root_mkdir(struct inode *,struct dentry *,int);
>  static long autofs_root_ioctl(struct file *,unsigned int,unsigned long);
> +#ifdef CONFIG_COMPAT
>  static long autofs_root_compat_ioctl(struct file *,unsigned int,unsigned long);
> +#endif
>
>  const struct file_operations autofs_root_operations = {
>        .llseek         = generic_file_llseek,

An alternative (and IMHO better) fix would be to move autofs_root_operations[]
and autofs_root_inode_operations[] to the bottom of the file, and get rid of all
the forward declarations.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/