linux-kernel - Re: [PATCH] staging: ft1000: fix skb, netdev, memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100930195307.GA30952@suse.de>
Date:	Thu, 30 Sep 2010 12:53:07 -0700
From:	Greg KH <gregkh@...e.de>
To:	Vasiliy Kulikov <segooon@...il.com>
Cc:	Greg KH <greg@...ah.com>, kernel-janitors@...r.kernel.org,
	devel@...verdev.osuosl.org,
	Marek Belisko <marek.belisko@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ft1000: fix skb, netdev, memory leaks

On Thu, Sep 30, 2010 at 11:23:03PM +0400, Vasiliy Kulikov wrote:
> On Thu, Sep 30, 2010 at 04:13 -0700, Greg KH wrote:
> > On Tue, Sep 28, 2010 at 09:49:35PM +0400, Vasiliy Kulikov wrote:
> > > ft1000_copy_up_pkt() doesn't free skb on errors.
> > > init_ft1000_card() doesn't free netdev with free_netdev() but with kfree().
> > > init_ft1000_card() doesn't check request_region()'s return value
> > > and doesn't free region on error.
> > > 
> > > Signed-off-by: Vasiliy Kulikov <segooon@...il.com>
> > > ---
> > >  Compile tested.
> > 
> > No you didn't
> 
> No I did:
> 
> make -C /home/vasya/linux drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.o
> make: Вход в каталог `/home/vasya/dev/linux-next'
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CALL    scripts/checksyscalls.sh
>   CC      drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.o
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c: In function ‘ft1000_reset_card’:
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:525: warning: passing argument 2 of ‘card_download’ discards qualifiers from pointer target type
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c:56: note: expected ‘void *’ but argument is of type ‘const u8 * const’
> make: Выход из каталога `/home/vasya/dev/linux-next'

Heh, I didn't think to try that, amazed that it worked at all.

> However, 
> 
>     cd ../drivers/staging/ft1000/ft1000-pcmcia/
>     LANG=C make -C ~/linux ft1000_hw.o
>     make: Entering directory `/home/vasya/dev/linux-next'
>     make: *** No rule to make target `ft1000_hw.o'.  Stop.
>     make: Leaving directory `/home/vasya/dev/linux-next'
> 
> 
> Is "make" from linux root buggy/not supported for staging/everything?

This driver is marked broken, look at the Kconfig file:
	config FT1000_PCMCIA
	        tristate "Driver for ft1000 pcmcia device."
	        depends on PCMCIA && BROKEN


It will be fixed up soon hopefully.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/