linux-kernel - Re: [PATCH 1/2] autofs: Only declare function when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinQG-Jt5CVuYPrAFO2nYAkyKEt++SPC+sGKKUDr@mail.gmail.com>
Date:	Thu, 30 Sep 2010 22:37:07 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Márton Németh <nm127@...email.hu>,
	Arnd Bergmann <arnd@...db.de>, Ian Kent <raven@...maw.net>
Subject: Re: [PATCH 1/2] autofs: Only declare function when CONFIG_COMPAT is defined

On Thu, Sep 30, 2010 at 22:20, H. Peter Anvin <hpa@...or.com> wrote:
> On 09/30/2010 01:00 PM, Geert Uytterhoeven wrote:
>>
>> An alternative (and IMHO better) fix would be to move autofs_root_operations[]
>> and autofs_root_inode_operations[] to the bottom of the file, and get rid of all
>> the forward declarations.
>>
>
> This is a legacy piece of code (autofs3) which has been long since
> obsolete anyway... it's one thing to do a minimal patch to keep it
> alive, another to restructure crap when it's already overdue for removal.

You're right. But please note that autofs4 has the exact same issue.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/