linux-kernel - Re: [RESEND PATCH] cpufreq: unnecesary double free in pcc_cpufreq_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101001052540.GA31519@redhat.com>
Date:	Fri, 1 Oct 2010 01:25:41 -0400
From:	Dave Jones <davej@...hat.com>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	dave@....org, cpufreq@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	x86 maintainers <x86@...nel.org>
Subject: Re: [RESEND PATCH] cpufreq: unnecesary double free in
 pcc_cpufreq_do_osc

On Fri, Oct 01, 2010 at 07:47:23AM +0300, Pekka Enberg wrote:

 > > I think Dave's patch is correct.  There's a kfree(output.pointer) at line 359.
 > > If we fall all the way through without hitting any of the return -ENODEVs,
 > > we end up doing a 2nd kfree in the out_free:
 > 
 > There's a second call to acpi_evaluate_object() which takes "output" as 
 > its argument and allocates more memory.

yup. I merged your patch. after it's soaked in -next for a day, I'll push it to
Linus.  (Looks obviously correct, but just being extra careful given where
we are in the release cycle)

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/