linux-kernel - Re: [RESEND/PATCH] usb: gadget: goku

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101004122214.GA5692@bicker>
Date:	Mon, 4 Oct 2010 14:22:14 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Rahul Ruikar <rahul.ruikar@...il.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>, nm127@...email.hu,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND/PATCH] usb: gadget: goku_udc: Fix error path

On Mon, Oct 04, 2010 at 01:29:00AM +0530, Rahul Ruikar wrote:
> call put_device() when device_register() fails.
> 

Sorry I didn't realize what you were trying to do here.  This is not
correct at all.

The right thing is to fix device_register() to call put_device() itself.
It's a bit involved, because all the callers will need to be audited but
someone is working on this I think.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/