linux-kernel - Re: Dynamic nop selection breaks boot on Geode LX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101004203921.GG2900@redhat.com>
Date:	Mon, 4 Oct 2010 16:39:22 -0400
From:	Jason Baron <jbaron@...hat.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Daniel Drake <dsd@...top.org>,
	Andres Salomon <dilinger@...ued.net>,
	Chris Ball <cjb@...top.org>, linux-kernel@...r.kernel.org,
	mingo@...e.hu
Subject: Re: Dynamic nop selection breaks boot on Geode LX

On Mon, Oct 04, 2010 at 04:31:12PM -0400, Steven Rostedt wrote:
> On Mon, 2010-10-04 at 11:46 -0400, Jason Baron wrote:
> 
> >  	restart_nmi();
> > +
> > +	local_irq_save(flags);
> > +	arch_init_ideal_nop5();
> > +	local_irq_restore(flags);
> >  }
> >  
> >  /**
> 
> BTW, why the irq disabling around the call?
> 
> -- Steve
> 
> 

Only b/c the selection of the nop was originally done by
'ftrace_dyn_arch_init()' which had irq's disabled around it. So maybe
that can be dropped now?

thanks,

-Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/