lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 04 Oct 2010 14:50:35 -0700
From:	"H. Peter Anvin" <>
To:	Borislav Petkov <>,
	Linus Torvalds <>,
	Ingo Molnar <>,
	Thomas Gleixner <>,
	lkml <>
Subject: Re: [PATCH] x86, cpu: Fix X86_FEATURE_NOPL

>> Agreed that this should be cleaned up.  However, in the meantime I'd
>> like to keep Borislav's patch in the tree since it makes the code
>> technically correct at least.
> I think the cleanup should be easy: on 64-bit unconditionally return
> p6_nops in find_nop_table() since every 64-bit processor should support
> them and on 32-bit never return p6_nops since X86_FEATURE_NOPL is not
> set there and fall back to intel_nops on non-AMD. Which means we can get
> rid of X86_FEATURE_NOPL altogether. Too radical?

This is fine with me, but you may want to check with your employer if
the Intel NOPs will perform slower than the 66 ... 90 NOPs on AMD

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists