linux-kernel - Re: [BUG 2.6.36-rc6] list corruption in module_bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimbEnwPaAvvNN3NCt7Nzx6FG2hbr4QurT5-YukN@mail.gmail.com>
Date:	Mon, 4 Oct 2010 16:55:52 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Arnd Bergmann <arnd@...db.de>, LKML <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Kay Sievers <kay.sievers@...y.org>,
	Brandon Philips <brandon@...p.org>
Subject: Re: [BUG 2.6.36-rc6] list corruption in module_bug_finalize

On Mon, Oct 4, 2010 at 3:43 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
>
> The patch below cures it.

Hmm. I think I'd rather move the module_bug_finalize() call away from
the arch-specific module_finalize(), and down later into
load_module().

Basically, we simply shouldn't be doing global things that need the
'module_mutex' until after we've done all the local things, and then
checked for uniqueness.

And I don't see why module_bug_finalize() (and module_bug_cleanup) is
called from arch-specific code anyway. I think that placement is
purely historical.

It would seem to make most sense to do the module_bug_finalize() in
the same location where we add the module to the list of modules.

IOW, a patch like the attached. UNTESTED!

                    Linus

View attachment "patch.diff" of type "text/x-patch" (6497 bytes)