linux-kernel - Re: [BUG 2.6.36-rc6] list corruption in module_bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimzo_Kmm5HdCdGLnnFrpVMKNpvjhO7F357FW+kO@mail.gmail.com>
Date:	Mon, 4 Oct 2010 18:11:34 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Arnd Bergmann <arnd@...db.de>, LKML <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Kay Sievers <kay.sievers@...y.org>,
	Brandon Philips <brandon@...p.org>
Subject: Re: [BUG 2.6.36-rc6] list corruption in module_bug_finalize

On Mon, Oct 4, 2010 at 4:55 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> It would seem to make most sense to do the module_bug_finalize() in
> the same location where we add the module to the list of modules.
>
> IOW, a patch like the attached. UNTESTED!

That patch is still untested, but reading through it once more I
noticed that I forgot to add the module_bug_cleanup() call to the
module exit path.

So here's a trivially fixed version that has the module unload doing
the bug cleanup too.

I also suspect that the whole 'module_bug_{finalize,cleanup}()' thing
should probably be moved to kernel/module.c, but that's a separate
issue entirely.

                           Linus

View attachment "patch.diff" of type "text/x-patch" (6659 bytes)