linux-kernel - Re: [PATCH] Globally s/struct irq_host/struct irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 5 Oct 2010 09:25:44 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Grant Likely <grant.likely@...retlab.ca>
cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Jon Loeliger <jdl@....com>, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH] Globally s/struct irq_host/struct irq_domain/

On Mon, 4 Oct 2010, Grant Likely wrote:

> On Mon, Oct 4, 2010 at 5:09 PM, Benjamin Herrenschmidt
> <benh@...nel.crashing.org> wrote:
> > On Mon, 2010-10-04 at 10:52 -0600, Grant Likely wrote:
> >> On Sun, Oct 03, 2010 at 02:03:57PM -0500, Jon Loeliger wrote:
> >> >
> >> > Just rename the irq_host structure as irq_domain to lessen the
> >> > confusion around the word "host".  Updated a few comments and
> >> > error messages to use "irq_domain" when refering to the structure.
> >> >
> >> > Suggested by Ben Herrenschmidt on the device-tree mailing list.
> >> >
> >> > Signed-off-by: Jon Loeliger <jdl@....com>
> >> > ---
> >> >
> >> > Grant requested one giant patch simply renaming the structure.
> >>
> >> Thanks Jon,
> >>
> >> However, considering that tglx has already embarked on his Grand IRQ
> >> Subsystem Cleanup, I suspect that this will end up just getting in the
> >> way unless he picks it up into his queue.  It may even by that the
> >> need for irq_host will disappear once Thomas is finished by merging it
> >> into the core code.  I'd like to sit tight on this until the details
> >> of what powerpc virqs can be worked out with Ben and Thomas.
> >
> > I doubt the need for irq_host will disappear. However I don't see that
> > going into the core under that name, so I think the rename is a very
> > valid thing to do now. We just need to sync the patches to avoid pure
> > mechanical clash.
> >
> > Thomas initial series doesn't yet generalize the virq layer and that
> > will take a bit longer, so I'm happy to see Jon stuff go upstream first.
> 
> Alright, should tglx pick up this patch, or do you want to carry it in
> the powerpc tree?

Should go through powerpc.

       tglx