linux-kernel - Re: [PATCH] Globally s/struct irq_host/struct irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimGtuq8+yA121xg0tVQ=Z=nqfzUG6BC8YqzX3Qh@mail.gmail.com>
Date:	Mon, 4 Oct 2010 21:00:50 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Jon Loeliger <jdl@....com>, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org, tglx@...utronix.de
Subject: Re: [PATCH] Globally s/struct irq_host/struct irq_domain/

On Mon, Oct 4, 2010 at 5:09 PM, Benjamin Herrenschmidt
<benh@...nel.crashing.org> wrote:
> On Mon, 2010-10-04 at 10:52 -0600, Grant Likely wrote:
>> On Sun, Oct 03, 2010 at 02:03:57PM -0500, Jon Loeliger wrote:
>> >
>> > Just rename the irq_host structure as irq_domain to lessen the
>> > confusion around the word "host".  Updated a few comments and
>> > error messages to use "irq_domain" when refering to the structure.
>> >
>> > Suggested by Ben Herrenschmidt on the device-tree mailing list.
>> >
>> > Signed-off-by: Jon Loeliger <jdl@....com>
>> > ---
>> >
>> > Grant requested one giant patch simply renaming the structure.
>>
>> Thanks Jon,
>>
>> However, considering that tglx has already embarked on his Grand IRQ
>> Subsystem Cleanup, I suspect that this will end up just getting in the
>> way unless he picks it up into his queue.  It may even by that the
>> need for irq_host will disappear once Thomas is finished by merging it
>> into the core code.  I'd like to sit tight on this until the details
>> of what powerpc virqs can be worked out with Ben and Thomas.
>
> I doubt the need for irq_host will disappear. However I don't see that
> going into the core under that name, so I think the rename is a very
> valid thing to do now. We just need to sync the patches to avoid pure
> mechanical clash.
>
> Thomas initial series doesn't yet generalize the virq layer and that
> will take a bit longer, so I'm happy to see Jon stuff go upstream first.

Alright, should tglx pick up this patch, or do you want to carry it in
the powerpc tree?

g.

>
> What hopefully will go away is the big irq_map array, I hope to put the
> domain & hw_number information in the irq_desc or irq_data eventually.
>
>> Also, sorry for sending you down this rabbit hole.  When I suggested
>> this I didn't realize how quickly Thomas was going to get started on
>> his rework.
>
> Cheers,
> Ben.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/