linux-kernel - Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimie7QnHGoP2UwvqfqETiBUJ42xmB2YM7OAJXdq@mail.gmail.com>
Date:	Thu, 7 Oct 2010 16:18:32 +0530
From:	Rabin Vincent <rabin@....in>
To:	Joe Perches <joe@...ches.com>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable files
 created with non 100644 file permissions

On Thu, Oct 7, 2010 at 5:01 AM, Joe Perches <joe@...ches.com> wrote:
> +               if ($rawline =~ /^ create mode (\d+) ([\w\.\/\-]+)$/) {
> +                       my $mode = $1;
> +                       my $file = $2;
> +                       if ($mode ne "100644" && !($file =~ /\.(sh|pl|py|awk)$/)) {
> +                               WARN("FILE '$file' should probably use file permission 100644 not $mode\n" . $herecurr);
> +                       }
> +               }
> +

There's a vaguely similar patch already in -mm.  That one also handles mode
changes and doesn't require the presence of the diff summary.  Have a look in
case you missed it, maybe it does most of what you want and you can base
something on that:

http://userweb.kernel.org/~akpm/mmotm/broken-out/checkpatch-check-for-incorrect-permissions.patch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/