linux-kernel - Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable files created with non 100644 file permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CB32199.1000401@suse.cz>
Date:	Mon, 11 Oct 2010 16:39:21 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Warn on non-executable files	created
 with non 100644 file permissions

On 7.10.2010 08:54, Wolfram Sang wrote:
> On Wed, Oct 06, 2010 at 04:31:31PM -0700, Joe Perches wrote:
>> +			my $mode = $1;
>> +			my $file = $2;
>> +			if ($mode ne "100644" && !($file =~ /\.(sh|pl|py|awk)$/)) {
>> +				WARN("FILE '$file' should probably use file permission 100644 not $mode\n" . $herecurr);
>> +			}
> 
> What about checking for no filename extension, too, and changing the message to
> something like "use proper file permission or proper extension"?

That would result in too many false positives, I'm afraid. What about
checking for files with a shebang?

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/