linux-kernel - Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1B7E8A0C-6ADB-49A5-B21F-76D19364A96F@kernel.crashing.org>
Date:	Thu, 7 Oct 2010 08:21:47 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Scott Wood <scottwood@...escale.com>,
	Peter Tyser <ptyser@...-inc.com>, linux-kernel@...r.kernel.org,
	Dave Jiang <djiang@...sta.com>, linuxppc-dev@...abs.org,
	Doug Thompson <dougthompson@...ssion.com>
Subject: Re: [PATCH] edac: mpc85xx: Add support for new MPCxxx/Pxxxx EDAC controllers (fix)


On Oct 7, 2010, at 2:12 AM, Anton Vorontsov wrote:

> On Thu, Oct 07, 2010 at 02:00:50AM -0500, Kumar Gala wrote:
>> 
>> On Oct 7, 2010, at 1:37 AM, Kumar Gala wrote:
>> 
>>>> @ -1125,7 +1128,10 @@ static struct of_device_id mpc85xx_mc_err_of_match[] = {
>>>> 	{ .compatible = "fsl,mpc8569-memory-controller", },
>>>> 	{ .compatible = "fsl,mpc8572-memory-controller", },
>>>> 	{ .compatible = "fsl,mpc8349-memory-controller", },
>>>> +	{ .compatible = "fsl,p1020-memory-controller", },
>>>> +	{ .compatible = "fsl,p1021-memory-controller", },
>>>> 	{ .compatible = "fsl,p2020-memory-controller", },
>>>> +	{ .compatible = "fsl,p4080-memory-controller", },
>>> 
>>> This line should be here ;)
>> 
>> should NOT be here.
> 
> Hm. Are you sure? I thought that only L2 cache controller is
> not applicable (and based on Scott's comment I removed
> the l2 cache compatible entry for p4080). But I guess
> memory-controller is somewhat similar to all other 85xx?
> 
> If it's not, I can surely prepare a patch that removes
> p4080 entry.
> 
> Thanks,

Your correct, late night and looking at the wrong line.  It was the L2 that should have been removed.  Ignore me.

- k--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/