linux-kernel - Re: [PATCH] OLPC: Add XO-1 poweroff support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101007142003.68b6ad7e@debxo>
Date:	Thu, 7 Oct 2010 14:20:03 -0700
From:	Andres Salomon <dilinger@...ued.net>
To:	Daniel Drake <dsd@...top.org>
Cc:	tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] OLPC: Add XO-1 poweroff support

On Thu, 7 Oct 2010 21:42:59 +0100
Daniel Drake <dsd@...top.org> wrote:

> On 7 October 2010 21:09, Andres Salomon <dilinger@...ued.net> wrote:
> > Any particular reason why this can't be modular?
> 
> Because of the pm_power_off thing.
> Also, a similar situation would be encountered with set_suspend_ops().
> 
> I don't really understand your suggestion. If we set it to NULL on
> module unload then the power off would crash on shutdown, right?
> 
> Daniel


See arch/x86/kernel/apm_32.c for an example of modular pm_power_off
handling.

Power off shouldn't crash; at least, native_machine_power_off first
check if pm_power_off is !NULL before calling it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/