linux-kernel - Re: [PATCH 04/18] fs: Implement lazy LRU updates for inodes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101008090802.GV19804@ZenIV.linux.org.uk>
Date:	Fri, 8 Oct 2010 10:08:02 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Dave Chinner <david@...morbit.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/18] fs: Implement lazy LRU updates for inodes.

On Fri, Oct 08, 2010 at 04:21:18PM +1100, Dave Chinner wrote:

>  void __iget(struct inode *inode)
>  {
> -	if (atomic_inc_return(&inode->i_count) != 1)
> -		return;
> -
> -	if (!(inode->i_state & (I_DIRTY|I_SYNC)))
> -		list_move(&inode->i_list, &inode_in_use);
> -	percpu_counter_dec(&nr_inodes_unused);
> +	atomic_inc(&inode->i_count);
>  }

Umm...  Are you sure we don't rely on implict barriers present in the current
version?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/