linux-kernel - Re: [PATCH 09/18] fs: rework icount to be a locked variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101008135303.GA15316@infradead.org>
Date:	Fri, 8 Oct 2010 09:53:04 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Dave Chinner <david@...morbit.com>
Cc:	Al Viro <viro@...IV.linux.org.uk>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/18] fs: rework icount to be a locked variable

On Fri, Oct 08, 2010 at 09:15:49PM +1100, Dave Chinner wrote:
> > You are overdoing the information hiding here; _way_ too many small
> > functions that don't buy you anything so far, AFAICS.
> 
> See akpm's comments on the previous version of the series.

It's one persons opinion.  I tend to disagree with lots of it.  iref
is a good new helper for filesystems to use, but for the unlocked
read it's reather pointless.  iref_locked is even more pointless -
it's only used in core fs code (fs/inode.c, fs/fs-writeback.c,
fs/drop_caches.c, fs/notify/inode_mark.c and fs/quota/dquot.c) and
an opencoded increment would be a lot more readable.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/