linux-kernel - Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101008134654.GA6600@kroah.com>
Date:	Fri, 8 Oct 2010 06:46:54 -0700
From:	Greg KH <greg@...ah.com>
To:	matt mooney <mfmooney@...il.com>
Cc:	T Dent <tdent48227@...il.com>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, sam@...nborg.org,
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y

On Fri, Oct 08, 2010 at 12:16:35AM -0700, matt mooney wrote:
> On Thu, Oct 7, 2010 at 6:35 PM, T Dent <tdent48227@...il.com> wrote:
> > I patch against the next-20101006 tree.
> >
> > The patch series replace use of <module>-objs with <module>-y in the
> > staging directory.
> 
> Commit messages are written in the present tense. You happen to be
> using two different tenses within the commit message, which is truly
> odd.  And why did you not split apart those atrocious statements with
> the infinite column width?

As Dan said, we understand what is happening here, and we do not have
grammer police for changelog comments, thank goodness.

> This patch series adds little benefit.  As Sam has suggested, a more
> general cleanup would be a better goal, and staging is an area that
> needs extra attention some of which has already been pointed out in
> other emails.

But these patches are all good to have, so I will be applying them,
please don't think they are unwanted at all.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/