linux-kernel - Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Oct 2010 11:05:20 -0700
From:	matt mooney <mfmooney@...il.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	T Dent <tdent48227@...il.com>, greg@...ah.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	sam@...nborg.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y

On Fri, Oct 8, 2010 at 1:55 AM, Dan Carpenter <error27@...il.com> wrote:
> On Fri, Oct 08, 2010 at 12:16:35AM -0700, matt mooney wrote:
>> On Thu, Oct 7, 2010 at 6:35 PM, T Dent <tdent48227@...il.com> wrote:
>> > I patch against the next-20101006 tree.
>> >
>> > The patch series replace use of <module>-objs with <module>-y in the
>> > staging directory.
>>
>> Commit messages are written in the present tense. You happen to be
>> using two different tenses within the commit message, which is truly
>> odd.
>
> Maybe *you* write in the present tense.  Commit messages are important,

This is not my convention; I also wrote my first few patches in the
past tense but noticed they were changed to the present.

> yes, but this in the end we all understood the message fine.  Please
> don't be a jerk.

Rereading what I wrote, I realize it can be interpreted as being rude,
but I think that is due to my direct writing style. My tone while
writing it was very lighthearted although without knowing me I
completely understand how it could come off wrong. To clarify, I
thought it was odd because the two lines (subject and body) basically
said the same thing using different verb tenses; my aim was not to
pick apart the grammar.

Thanks,
mfm


-- 
GPG-Key: 9AFE00EA
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/